Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern argument #2

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Add pattern argument #2

merged 2 commits into from
Feb 29, 2024

Conversation

hoshinotsuyoshi
Copy link
Collaborator

@hoshinotsuyoshi hoshinotsuyoshi commented Feb 26, 2024

Added pattern argument.

Note: Unlike the arguments handled by this graphql-constraint-directive gem (maxLength, minLength, etc.), validation is not performed on the graphql-ruby side. I am determined to validate regular expressions with the model on the rails app side.

@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review February 28, 2024 02:50
@MH4GF
Copy link

MH4GF commented Feb 28, 2024

Note: Unlike the arguments handled by this graphql-constraint-directive gem (maxLength, minLength, etc.), validation is not performed on the graphql-ruby side. I am determined to validate regular expressions with the model on the rails app side.

suggestion: I thought the above information could also be added to the README. I think (unimplemented) should be removed as well.

#### pattern(unimplemented)

@hoshinotsuyoshi
Copy link
Collaborator Author

Note: Unlike the arguments handled by this graphql-constraint-directive gem (maxLength, minLength, etc.), validation is not performed on the graphql-ruby side. I am determined to validate regular expressions with the model on the rails app side.

suggestion: I thought the above information could also be added to the README. I think (unimplemented) should be removed as well.

Updated! 6df37c2 @MH4GF

Copy link

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Base automatically changed from update_gemspec to main February 29, 2024 03:25
@hoshinotsuyoshi hoshinotsuyoshi merged commit 6df37c2 into main Feb 29, 2024
1 check passed
@hoshinotsuyoshi hoshinotsuyoshi deleted the add-regexp-pattern branch February 29, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants