Speed up

route06 · Jan 29, 2024 · b512b93 · b512b93
1 parent cc1a5ec
commit b512b93
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/lib/rubocop/cop/grep/grep.rb b/lib/rubocop/cop/grep/grep.rb
@@ -21,8 +21,8 @@ def on_new_investigation
               re = Regexp.new(pat, opt)
               from = 0
               while m = re.match(source, from)
-                if match_comment || !in_comment?(m)
-                  pos = position_from_matchdata(m)
+                pos = position_from_matchdata(m)
+                if match_comment || !in_comment?(pos)
                   range = source_range(processed_source.buffer, pos[:line], pos[:column], pos[:length])
                   add_offense(range, message: rule['Message'])
                 end
@@ -42,8 +42,7 @@ def on_new_investigation
           { line: line, column: column, length: length }
         end
 
-        private def in_comment?(m)
-          pos = position_from_matchdata(m)
+        private def in_comment?(pos)
           processed_source.comments.any? do |c|
             c.loc.line == pos[:line] && c.loc.expression.begin_pos <= pos[:column]
           end

diff --git a/sig/rubocop/cop/cop/grep.rbs b/sig/rubocop/cop/cop/grep.rbs
@@ -27,7 +27,11 @@ module RuboCop
           length: Integer,
         }
 
-        private def in_comment?: (MatchData) -> bool
+        private def in_comment?: ({
+          line: Integer,
+          column: Integer,
+          length: Integer,
+        }) -> bool
 
         private def regexp_option: (rule) -> Integer