Make RuboCop FactoryBot work as a RuboCop plugin #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
commented
Feb 17, 2025
| @@ -23,7 +23,9 @@ RSpec::Core::RakeTask.new(:spec) do |spec| | |||
| end | |||
|
|
|||
| desc 'Run RuboCop over this gem' | |||
| RuboCop::RakeTask.new(:internal_investigation) | |||
| RuboCop::RakeTask.new(:internal_investigation) do | |||
| RuboCop::ConfigLoader.inject_defaults!("#{__dir__}/config/default.yml") | |||
There was a problem hiding this comment.
I don’t understand why this is necessary, and hope to remove it before merging the PR.
bquorning
force-pushed
the
rubocop-plugin
branch
3 times, most recently
from
6398865 to
8e293e7
Compare
This pull request adds support for RuboCop's plugin feature, added in rubocop/rubocop#13792, released in v1.72. It replaces the ad-hoc `inject_defaults!` with RuboCop plugins. Some Rake tasks may still need to use `inject_defaults!`.
bquorning
force-pushed
the
rubocop-plugin
branch
from
8e293e7 to
b5a0170
Compare
|
CI failure seems to be caused by the the same issue as rubocop/rubocop-rspec#2044 |
|
@koic Thank you for your help so far in rubocop-rspec. But could I ask you to also have a look at this PR, and at rubocop/rubocop-capybara#144 too? In this PR it seems I get different results from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for RuboCop's plugin feature, added in rubocop/rubocop#13792, released in v1.72.
It replaces the ad-hoc
inject_defaults!with RuboCop plugins.Some Rake tasks may still need to use
inject_defaults!.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).