Skip to content

Commit

Permalink
Merge pull request #10 from dli7319/master
Browse files Browse the repository at this point in the history
Add a unit test
  • Loading branch information
dli7319 authored Apr 9, 2024
2 parents 306bc56 + 8270271 commit 4984df2
Show file tree
Hide file tree
Showing 6 changed files with 88 additions and 2 deletions.
40 changes: 40 additions & 0 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# This workflow will install Python dependencies, run tests and lint with a single version of Python
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python

name: Run pytest

on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]
workflow_dispatch: {}

permissions:
contents: read

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: Set up Python 3.10
uses: actions/setup-python@v3
with:
python-version: "3.10"
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
# flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
- name: Test with pytest
run: |
pytest
4 changes: 2 additions & 2 deletions DuBibtex.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class Parser:
# current bibitem and bib ID
cur, bib = None, ''

def __init__(self):
def __init__(self, output_file=None):
config = configparser.ConfigParser()
config.read("config.ini")
Paras.header['User-Agent'] = config.get(Paras.section, "header").strip()
Expand All @@ -95,7 +95,7 @@ def __init__(self):
Paras.inputFileList = config.get(Paras.section,
"inputFileList").strip().split(",")
Paras.doiJsonFile = config.get(Paras.section, "doiJsonFile").strip()
Paras.outputFile = config.get(Paras.section, "outputFile").strip()
Paras.outputFile = output_file if output_file else config.get(Paras.section, "outputFile").strip()
Paras.fieldRemovalList = config.get(Paras.section,
"fieldRemovalList").strip().split(",")
Paras.minYear = config.getint(Paras.section, "minYear")
Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[tool.pytest.ini_options]
pythonpath = [
"."
]
1 change: 1 addition & 0 deletions tests/inputs/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
!*
8 changes: 8 additions & 0 deletions tests/inputs/signet.bib
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
@INPROCEEDINGS{feng2021signet,
author={Feng, Brandon Yushan and Varshney, Amitabh},
booktitle={2021 IEEE/CVF International Conference on Computer Vision (ICCV)},
title={{SIGNET}: Efficient Neural Representation for Light Fields},
year={2021},
volume={},
number={},
pages={14204-14213}}
33 changes: 33 additions & 0 deletions tests/test_find_dois.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import unittest
import tempfile
import os

import bibtexparser

from DuBibtex import Parser



class TestFindDOIs(unittest.TestCase):


def test_iccv_doi(self):
filename = "tests/inputs/signet.bib"
correct_doi = "10.1109/ICCV48922.2021.01396"

self.assertTrue(os.path.isfile(filename))
library = bibtexparser.parse_file(filename)

with tempfile.NamedTemporaryFile() as fp:
p = Parser(output_file=fp.name)
for entry in library.entries:
p.copy_from_parsed_entry(entry)
p.write_current_item()
p.shut_down()

# Check the doi
generated_library = bibtexparser.parse_file(fp.name)
self.assertEqual(len(generated_library.entries), len(library.entries), "Number of entries should be the same")
for entry in generated_library.entries:
self.assertTrue("doi" in entry)
self.assertEqual(entry.fields_dict["doi"].value, correct_doi)

0 comments on commit 4984df2

Please sign in to comment.