-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new libs team #707
Add new libs team #707
Conversation
If it's just me, who reviews the PRs I send? Or I just self-merge? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved, but it needs more members. I can help if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
I can also help if more members are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reminder also to add to rust-lang/teams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The libs team at last! Thank you! :)
It looks like there are a couple of volunteers already, so hopefully the first approval can be for additional team members! I'm also happy to join so should probably have put my name on the list to begin with 😅 |
looks great. After I finish the translation work for several warehouses, I also want to try applying and see if I can join the resource team. |
b5b5401
a013404
to
b5b5401
Compare
Thanks everyone, and welcome to the new libs team! @thejpster, @newAM, having more members would be great, please open a PR adding yourselves if you're happy to help out! |
We've had a few crates that do not obviously fit into either HAL, resources, tools, or an architecture-specific team. I think a libs team is the easiest way to handle these.
Specifically:
heapless
into the working group for ongoing maintenance, but it doesn't fit into any existing teamvolatile-register
qemu-exit
is in the wg but currently team-less because it doesn't fit obviously into anything elsefixedvec-rs
is in the wg for legacy reasons, but probably makes sense under a "libs" team (or to be archived in favour of heapless, @nastevens?)mutex-trait
intoresources
as a weird compromise, although these days it's probably within the remit of the HAL team which handle most "shared traits"bare-metal
is maintained by every single architecture team, which is a bit of a mess, but again these days might fall within the remit of the HAL teamr0
is mercifully deprecated now but was maintained by every team and would much more obviously fit into a "libs" teamFor now I propose creating the team and adding @Dirbaio who has volunteered. Initially it just contains
embedded-alloc
moved from thecortex-m
team andqemu-exit
which doesn't currently have a team; hopefully we can moveheapless
andvolatile-register
in once the team is established.This PR also repositions the infrastructure team to restore the team list to alphabetical order (it used to be called ops team, hence its previous position in the list).
The wg doesn't have a fixed policy (as far as I can find) for creating a new team, so our usual approach would be a whole WG vote. We currently have 25 unique members listed on the README across all teams, so would need 13 approvals in the next week, or 9 within the next 3 weeks. Previously new teams were made with this process in #209 (ops team) and #317 (ecosystem team, approved but never merged or created).
If you're a wg member, please indicate if you approve by approving this PR, or if not, please comment with any concerns or discuss in the weekly meeting.
You can tick yourself off below as well if you like, or I will to keep in sync with the approvals, but please leave an approving review first.