Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size of time_t in vxworks #4268

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix size of time_t in vxworks #4268

merged 1 commit into from
Feb 18, 2025

Conversation

hax0kartik
Copy link
Contributor

@hax0kartik hax0kartik commented Feb 15, 2025

Description

This fixes the size of time_t in VxWorks which was incorrectly set to c_long. This broke compatibility with 32-bit targets.

Requesting stable-nomination.

Sources

VxWorks sources are copyrighted.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Checked locally on VxWorks.

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@hax0kartik
Copy link
Contributor Author

@rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Feb 15, 2025
@tgross35
Copy link
Contributor

Cc @jackorobot @biabbas would you be able to double check this?

I know there were some surprising differences on vxworks, from #4043.

@biabbas
Copy link
Contributor

biabbas commented Feb 18, 2025

@tgross35
Yes, this is correct. To avoid the problems like year 2038 problem, the default size of time_t on 32 bits VxWorks targets is 64 bits.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. Looks like this has existed since #1408 (cc @BaoshanPang)

@tgross35 tgross35 added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@tgross35 tgross35 added this pull request to the merge queue Feb 18, 2025
Merged via the queue into rust-lang:main with commit ca7695a Feb 18, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants