Apply review comments

src/shims/files.rs

@@ -1,7 +1,7 @@
 use std::any::Any;
 use std::collections::BTreeMap;
 use std::fs::{File, Metadata};
-use std::io::{IsTerminal, Read, SeekFrom, Seek, Write};
+use std::io::{IsTerminal, Read, Seek, SeekFrom, Write};
 use std::marker::CoercePointee;
 use std::ops::Deref;
 use std::rc::{Rc, Weak};
@@ -410,6 +410,9 @@ impl FileDescription for NullOutput {
     }
 }
 
+/// Internal type of a file-descriptor - this is what [`FdTable`] expects
+pub type FdNum = i32;
+
 /// The file descriptor table
 #[derive(Debug)]
 pub struct FdTable {
@@ -424,9 +427,6 @@ impl VisitProvenance for FdTable {
     }
 }
 
-/// Internal type of a file-descriptor - this is what [`FdTable`] expects
-pub type FdNum = i32;
-
 impl FdTable {
     fn new() -> Self {
         FdTable { fds: BTreeMap::new(), next_file_description_id: FdId(0) }

src/shims/windows/fs.rs

@@ -104,6 +104,9 @@ bitflags! {
         /// This must be passed to allow getting directory handles. If not passed, we error on trying
         /// to open directories
         const BACKUP_SEMANTICS = 1 << 1;
+        /// Open a reparse point as a regular file - this is basically similar to 'readlink' in Unix
+        /// terminology. A reparse point is a file with custom logic when navigated to, of which
+        /// a symlink is one specific example.
         const OPEN_REPARSE = 1 << 2;
     }
 }
@@ -251,7 +254,7 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
                     options.append(true);
                 }
             }
-            OpenExisting => (), // Nothing
+            OpenExisting => {} // Default options
             TruncateExisting => {
                 options.truncate(true);
             }