-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI for Febuary 2025 #156
Conversation
Either I ran the update script wrong or something else bitrotted with it and the certificate update went south. The new one seems completely wrong according to CI. |
``` Magic Nix Cache is deprecated Magic Nix Cache has been deprecated due to a change in the underlying GitHub APIs and will stop working on 1 February 2025. To continue caching Nix builds in GitHub Actions, use FlakeHub Cache instead. Replace... uses: DeterminateSystems/magic-nix-cache-action@main ...with... uses: DeterminateSystems/flakehub-cache-action@main For more details: https://dtr.mn/magic-nix-cache-eol ```
1d85ddc
to
232c4be
Compare
This is a new failure:
The error code in the headers corresponds to a generic verification failure, so that error message might be all we have:
I'm not sure what would be causing this. If I convert the PEM given to me by Firefox on
|
Someone elsewhere said that they saw this on a production macOS system and it was fixed eventually by updating macOS. I tried running the tests in macOS 15 ( |
d972640
to
a6e90eb
Compare
70218db
to
1cd27c1
Compare
As an update here, I was able to finally get the test failures reproducing locally 😦. Out of ideas I just tried updating the LE leaf certificate again since it renewed recently and that seemed to have just fixed the "standards compliance" issue macOS was upset about. I hope this doesn't happen again in the future because it seems to have just been completely random and opaque. As CI is now passing: @djc @cpu do you mind stamping this to get #158 unblocked? |
So weird! 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this
This PR does two things for CI maintenance:
update_valid_ee_certs.rs
letsencrypt.org
certificate is issued by the E6 intermediate instead of E5. To match I updated that chain's intermediate locally by downloading it from https://letsencrypt.org/certificates/.