Minion has the option to skip pillars #67216
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new boolean flag `--skip-init-pillar` to salt-call and a boolean option `skip_init_pillar: true` (default `false`) to minion config. Judicious skipping of the initial pillar, or the copy of pillar rendered upon minion startup, can greatly speed up things like `salt-call test.ping` and eliminate redundant pillar rendering. Warning: Enabling this in minion config is likely to break some pillar related functionality. `salt-call --no-skip-init-pillar` can be used to interactively override any `skip_init_pillar: true` config in `/etc/salt/minion` in the event that you do want the initial pillar (e.g. when using `salt-call pillar.get`). This flag is automatically supplied when `salt-call` detects that the function is from the pillar family.
dwoz
force-pushed
the
skip_initial_pillar
branch
from
657c2db to
36a643d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new boolean flag
--skip-init-pillarto salt-call and a boolean optionskip_init_pillar: true(defaultfalse) to minion config. Judicious skipping of the initial pillar, or the copy of pillar rendered upon minion startup, can greatly speed up things likesalt-call test.pingand eliminate redundant pillar rendering. Warning: Enabling this in minion config is likely to break some pillar related functionality.salt-call --no-skip-init-pillarcan be used to interactively override anyskip_init_pillar: trueconfig in/etc/salt/minionin the event that you do want the initial pillar (e.g. when usingsalt-call pillar.get). This flag is automatically supplied whensalt-calldetects that the function is from the pillar family.What does this PR do?
What issues does this PR fix or reference?
Fixes
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.