Skip to content

Commit

Permalink
nvidia: revert to old method and enforce /dev/dri device when it exists
Browse files Browse the repository at this point in the history
  • Loading branch information
saltydk committed Jan 27, 2025
1 parent 2d9ead2 commit b3bb426
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 17 deletions.
8 changes: 4 additions & 4 deletions resources/tasks/docker/create_docker_container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,7 @@
default_host_ip: ""
device_read_bps: "{{ lookup('vars', _var_prefix + '_docker_device_read_bps', default=omit) }}"
device_read_iops: "{{ lookup('vars', _var_prefix + '_docker_device_read_iops', default=omit) }}"
device_requests: "{{ nvidia_docker_device_requests
if use_nvidia
else lookup('vars', _var_prefix + '_docker_device_requests', default=omit) }}"
device_requests: "{{ lookup('vars', _var_prefix + '_docker_device_requests', default=omit) }}"
device_write_bps: "{{ lookup('vars', _var_prefix + '_docker_device_write_bps', default=omit) }}"
device_write_iops: "{{ lookup('vars', _var_prefix + '_docker_device_write_iops', default=omit) }}"
devices: "{{ lookup('vars', _var_prefix + '_docker_devices', default=omit) }}"
Expand All @@ -48,7 +46,9 @@
dns_servers: "{{ lookup('vars', _var_prefix + '_docker_dns_servers', default=omit) }}"
domainname: "{{ lookup('vars', _var_prefix + '_docker_domainname', default=omit) }}"
entrypoint: "{{ lookup('vars', _var_prefix + '_docker_entrypoint', default=omit) }}"
env: "{{ lookup('vars', _var_prefix + '_docker_envs', default=omit) }}"
env: "{{ (nvidia_docker_env if use_nvidia else {})
| combine(lookup('vars', _var_prefix + '_docker_envs', default={}))
| default(omit) }}"
env_file: "{{ lookup('vars', _var_prefix + '_docker_env_file', default=omit) }}"
etc_hosts: "{{ lookup('vars', _var_prefix + '_docker_hosts', default=omit)
if not ('container:' in lookup('vars', _var_prefix + '_docker_network_mode', default=docker_networks_name_common))
Expand Down
3 changes: 1 addition & 2 deletions resources/tasks/docker/set_docker_devices_variable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,4 @@

- name: Resources | Tasks | Docker | Set Docker Devices Variable | Set 'docker_devices' variable # noqa var-naming[no-jinja]
ansible.builtin.set_fact:
"{{ docker_devices_var_name }}": "{{ (['/dev/dri:/dev/dri'] if gpu.intel else [])
+ lookup('vars', role_name + '_docker_devices_default', default=[]) }}"
"{{ docker_devices_var_name }}": "{{ ['/dev/dri:/dev/dri'] + lookup('vars', role_name + '_docker_devices_default', default=[]) }}"
2 changes: 1 addition & 1 deletion roles/emby/tasks/main2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

- name: Docker Devices Task
ansible.builtin.include_tasks: "{{ resources_tasks_path }}/docker/set_docker_devices_variable.yml"
when: gpu.intel
when: gpu.intel or use_nvidia

- name: Create Docker container
ansible.builtin.include_tasks: "{{ resources_tasks_path }}/docker/create_docker_container.yml"
Expand Down
2 changes: 1 addition & 1 deletion roles/jellyfin/tasks/main2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

- name: Docker Devices Task
ansible.builtin.include_tasks: "{{ resources_tasks_path }}/docker/set_docker_devices_variable.yml"
when: gpu.intel
when: gpu.intel or use_nvidia

- name: Import preinstall task
ansible.builtin.import_tasks: "subtasks/preinstall.yml"
Expand Down
8 changes: 0 additions & 8 deletions roles/nvidia/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,6 @@ nvidia_nvtop_apt_repo_file: "/etc/apt/sources.list.d/flexiondotorg.list"
# Docker
################################

nvidia_docker_device_requests:
- driver: nvidia
count: -1
capabilities:
- - gpu
- compute
- utility

nvidia_docker_env:
NVIDIA_DRIVER_CAPABILITIES: "compute,video,utility"
NVIDIA_VISIBLE_DEVICES: "all"
Expand Down
2 changes: 1 addition & 1 deletion roles/plex/tasks/main2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@

- name: Docker Devices Task
ansible.builtin.include_tasks: "{{ resources_tasks_path }}/docker/set_docker_devices_variable.yml"
when: gpu.intel
when: gpu.intel or use_nvidia

- name: Create Docker container
ansible.builtin.include_tasks: "{{ resources_tasks_path }}/docker/create_docker_container.yml"
Expand Down

0 comments on commit b3bb426

Please sign in to comment.