antti/postgres #11
Merged
antti/postgres #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a new function called handleError
… and model data there
…ndlers and did some testing overall
…able function name from handleSomething -> handlePrisma
…ed updatedAt as well. Made id, createdAt and updateAt optional
…etion works instantly. Before gave an error due to wrong ID. Added some class tests
…se search. Added functionality to Delete request
…risma. Added a response if gift was deleted properly
…ated a file prismaClient.ts to try a global Prisma client
…t due to as CreateGift at the end
anttiasmala
commented
Feb 26, 2024
|
Kiitos jälleen tarkistuksesta! :) Nyt pitäisi olla kaikki korjailtu. Tähän neuvoon #11 (comment) viittaavia korjaamattomia tai väärin korjattuja kohtia saattanee löytyä, pitää tuota harjoitella ja testailla, jotta pystyn olemaan varma osaamisestani 😄 |
anttiasmala
commented
Feb 26, 2024
samuliasmala
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Kommenttien lisäksi tekisin vielä kaksi muutosta:
- README.md tiedostoon ohjeet miten otetaan käyttöön, eli
- Luo
.envtiedosto.env.exampletiedostosta - Aja migraatiot
npx prisma migrate deploy
- Luo
- Poistaisin kaikki migraatiot ja tyhjentäisin tietokannan, ja sitten generoisin skeemasta yhden uuden migraation niin poistuisi nuo testit.
… is more clear and contains every column
anttiasmala
commented
Feb 29, 2024
Comment on lines
+17
to
+36
| ### Setting the environment variables | ||
|
|
||
| Create `.env` file using `.env.example` as a template. | ||
|
|
||
| Change the DATABASE_URL variable to match your database user's details. | ||
|
|
||
| For example: `DATABASE_URL="postgresql://johndoe:JohnDoeDoesPostgres@localhost:5432/johnDB?schema=public"` | ||
|
|
||
| `johnDB` in DATABASE_URL can be named whatever wanted. Prisma will make a new database if it does not exist. | ||
|
|
||
| ### Run the migratiation | ||
|
|
||
| Run the migrations: | ||
|
|
||
| ```bash | ||
| npx prisma migrate deploy | ||
| ``` | ||
|
|
||
| after this, the database is set up! | ||
|
|
There was a problem hiding this comment.
En ole README.md tiedostoja koskaan tehnyt, joten en tiedä onko tuo ollenkaan hyvä. 😄 Onko esimerkiksi rivit 23 - 25 turhat?
There was a problem hiding this comment.
Hyvin kirjoitettu tuo. Ja ei ole rivit 23-25 turhia. Erityisesti on hyvä tieto, että tietokantaa ei tarvitse itse luoda, vaan Prisma tekee sen.
samuliasmala
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pohja tehty Postgresille