Antti/json server #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lders. Created a fetchFunctions file for all the functions needed for json-server.
…ons.tsx. Changed import fetchFunctions to jsonServerFunctions. Moved the jsonServerFunctions.tsx to utils folder and deleted json-server folder inside the utils folder
…function that fetches all the gifts from json-server 'backend'
…backend instead of localStorage. Made the gift prop to be mandatory instead of optional
…on works. Added JSDoc information
… be any instead of void
…ready. Created an useEffect to have a timer for hiding modal. Added an ability to change classNames of containers in Modal.tsx. Created InfoModal.tsx
…rver. Bypasses the error Axios gives to the console if the gift was deleted already
…stant variable names
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ted json-server folder due to no usage for now. Changed the db.json file location in package.json
samuliasmala
requested changes
Dec 22, 2023
icons/accept_button_icon.tsx
Outdated
There was a problem hiding this comment.
Muutitko tiedostoa tarkoituksella vai ajoitko svgr skriptin vahingossa?
There was a problem hiding this comment.
Tämä joko jäi korjaamatta tai jos muutit tiedostoa tarkoituksella niin sen voisi kommentoida tähän.
added 6 commits
January 9, 2024 19:15
…ror the error. Changed JSON_OBJECT variable to newGift to be more clarifying
…ateGift function which was not working. Removed return statement from functions that do not need it
icons/accept_button_icon.tsx
Outdated
There was a problem hiding this comment.
Tämä joko jäi korjaamatta tai jos muutit tiedostoa tarkoituksella niin sen voisi kommentoida tähän.
samuliasmala
requested changes
Jan 19, 2024
… returns as Gift type in jsonServerFunctions.ts
… SVG-icons get imported
samuliasmala
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensimmäinen versio json-server:stä.