Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill ireq.req with simple named requirement #265

Closed
wants to merge 1 commit into from
Closed

Fill ireq.req with simple named requirement #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/264.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug that non-wheel file requirements always fail on ``InstallRequirement.check_if_exists()``.
6 changes: 4 additions & 2 deletions src/requirementslib/models/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,8 +939,10 @@ def parse_ireq(self):
# type: () -> None
if self._ireq is None:
self._ireq = self.get_ireq()
if self._ireq is not None:
if self.requirement is not None and self._ireq.req is None:
if self._ireq is not None and self._ireq.req is None:
if self.is_file or self.is_remote_url:
self._ireq.req = PackagingRequirement(self.name)
elif self.requirement is not None:
self._ireq.req = self.requirement

def _parse_wheel(self):
Expand Down