Add support for color literals #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
requested changes
Jan 31, 2025
| { | ||
| "inputs": [ | ||
| { | ||
| "css": "@#{#00f}", |
There was a problem hiding this comment.
Is it intended for @ to be here?
There was a problem hiding this comment.
Yeah, because we didn't have variable statements early on the way we parse expressions is by creating an interpolation in an unknown at-rule.
| declare raws: ColorExpressionRaws; | ||
|
|
||
| /** | ||
| * The color represented by this expression. This will always be a color in |
There was a problem hiding this comment.
Why will it always be an RGB color? It doesn't seem like it's a limitation on sass_api 🤔
Is this a temporary limitation?
There was a problem hiding this comment.
Because Sass has no literal syntactic representation of non-RGB colors. Every other color type is returned by function calls.
Co-authored-by: Carlos (Goodwine) <[email protected]>
Goodwine
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.