Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clean player names of unwanted chars (#1008) #1009

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

Rushaway
Copy link
Contributor

Description

This pull request addresses the issue of unwanted non-standard characters in player names.
The code has been updated to remove these characters and handle cases where the name becomes empty after cleaning.

Motivation and Context

This change is required to ensure that player names are displayed and processed correctly without any non-standard or invisible characters. It fixes the issue where player names could appear empty or contain unexpected characters, improving data integrity and user experience.

Fixes #1008.

How Has This Been Tested?

The changes have been tested by running the application with various player names containing unwanted characters. The output was verified to ensure that the names were cleaned correctly and handled appropriately when empty.

Testing was conducted in a local development environment with a sample database.
The player name processing logic was verified to ensure no adverse effects on other parts of the application.

Output with some debugs:
[Original Player Name: 󠀡󠀡] [Hex Values: F3 A0 80 A1 F3 A0 80 A1 ] [Cleaned Player Name: ] [Hex Values After Cleaning: ]

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Rushaway
Copy link
Contributor Author

Marking as draft, I also have to update it for home page.

@Rushaway Rushaway marked this pull request as draft November 14, 2024 01:20
@Rushaway Rushaway marked this pull request as ready for review November 14, 2024 14:28
@Hackmastr Hackmastr merged commit b097269 into sbpp:php81 Nov 16, 2024
3 checks passed
@Rushaway Rushaway deleted the 1008-a branch November 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Player Names Contain Unwanted Non-Standard Characters
2 participants