Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): sbpp_checker library name #1034

Open
wants to merge 3 commits into
base: php81
Choose a base branch
from
Open

Conversation

Rushaway
Copy link
Contributor

@Rushaway Rushaway commented Jan 23, 2025

Description

Fix library name conflict between sbpp_checker and sbpp_main (both were using sourcebans++)

  • sbpp_main keeps sourcebans++
  • sbpp_checker now uses sourcebanspp_checker

This allows proper verification of specific libraries via LibraryExists and avoids any confusion between the two plugins.

Description

The main issue is a library name conflict where both sbpp_checker and sbpp_main were using the same name "sourcebans++" when registering their library via RegPluginLibrary. This was causing problems when checking for library existence with LibraryExists.

Motivation and Context

  • We are verifying for LibraryExists with sourcebans++ for using sbpp checker natives, wich was always incorrect to due the same RegPluginLibrary as sbpp_main.

How Has This Been Tested?

Tested with a test plugin implementing all new forwards:

  • Verified forward calls with PrintToServer
  • Tested plugin reload and pause scenarios
  • All forwards triggered as expected

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Rushaway
Copy link
Contributor Author

@Rushaway Rushaway marked this pull request as draft January 24, 2025 08:18
@rumblefrog
Copy link
Member

Is this ready for review, or still draft?

@Rushaway
Copy link
Contributor Author

Draft. I need to edit it later today.

@Rushaway Rushaway changed the title feat(API): Plugins status forwards & sbppchecker lib fix(API): sbpp_checker library name Jan 29, 2025
@Rushaway Rushaway marked this pull request as ready for review January 29, 2025 18:41
@Rushaway
Copy link
Contributor Author

@rumblefrog Ready to be merged with a squash commit.
This change can be a breaking change for others 3rd party plugins, but it worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants