Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for support for optional formData #123

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

add test for support for optional formData #123

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
802ca4a
initial commit
kainpets Nov 6, 2023
1699684
format
kainpets Nov 6, 2023
1d7593f
recreate formData not supporting z.object() inside test
kainpets Nov 7, 2023
66d9b2f
recreate issue in test
kainpets Nov 8, 2023
48859c3
nextlove supports .optional on formData
kainpets Nov 9, 2023
a5eb057
test withRouteSpec correctly validates formData
kainpets Nov 13, 2023
c82db13
formData returns correct response
kainpets Nov 13, 2023
8bd2224
use QueryString to test formData
kainpets Nov 14, 2023
66d9996
change import name to ES6
kainpets Nov 14, 2023
5f7889e
remove unused dependency
kainpets Nov 15, 2023
c874582
change the formData routeSpec schema
kainpets Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions apps/example-todo-app/pages/api/todo/form-add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@ import { z } from "zod"
import { v4 as uuidv4 } from "uuid"
kainpets marked this conversation as resolved.
Show resolved Hide resolved
import { HttpException } from "nextlove"

export const formData = z.object({
id: z.string().uuid().optional().default(uuidv4()),
title: z.string(),
completed: z.boolean().optional().default(false),
})
export const formData = z
.object({
id: z.string().uuid().optional().default(uuidv4()),
title: z.string(),
completed: z.boolean().optional().default(false),
})
.optional()

export const route_spec = checkRouteSpec({
methods: ["POST"],
Expand Down
33 changes: 32 additions & 1 deletion apps/example-todo-app/tests/api/todo/form-add.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import test from "ava"
import { TODO_ID } from "tests/fixtures"
import getTestServer from "tests/fixtures/get-test-server"
import { v4 as uuidv4 } from "uuid"
import { formData } from "pages/api/todo/form-add"
import { z } from "zod"

test("POST /todo/form-add", async (t) => {
const { axios } = await getTestServer(t)
Expand All @@ -23,3 +23,34 @@ test("POST /todo/form-add", async (t) => {

t.is(successfulRes.status, 200)
})

test("Valid formData object passes validation and returns successful response", async (t) => {
const { axios } = await getTestServer(t)

axios.defaults.headers.common.Authorization = `Bearer auth_token`

const bodyFormData = new URLSearchParams()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const bodyFormData = new URLSearchParams()
const bodyFormData = new FormData()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like FormData isn't supported. Seve created an issue to implement support for that: #127

bodyFormData.append("title", "clear_sandbox_state")

const successfulRes = await axios({
method: "POST",
url: "/todo/form-add",
data: bodyFormData,
headers: {
"Content-Type": "application/x-www-form-urlencoded",
},
}).catch((err) => err)
kainpets marked this conversation as resolved.
Show resolved Hide resolved

const validFormData = {
clear_sandbox_state: "clear_sandbox_state",
}

const validationResult = z
.object({
clear_sandbox_state: z.literal("clear_sandbox_state"),
})
.safeParse(validFormData)

t.true(validationResult.success)
t.is(successfulRes.status, 200)
})
Loading