Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: index backwards when extracting short token #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: index backwards when extracting short token #14

wants to merge 1 commit into from

Conversation

zlalvani
Copy link

@zlalvani zlalvani commented Feb 29, 2024 •
edited
Loading

fixes #13

seveibar
seveibar approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cc @codetheweb @razor-x seems ok to me

@razor-x
Copy link

razor-x commented Feb 29, 2024 •
edited
Loading

I think it's ok too, but this might be best released as a major version to alert consumers and avoid and parsing surprises. The docs / format should be updated to note the company part may contain underscores now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underscores in keyPrefix cause extractShortToken to return the wrong segment
3 participants
@zlalvani @razor-x @seveibar