fix: Handle non-json error responses #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrii-balitskyi we should be able to write a test for this at least for one case |
razor-x
reviewed
Feb 12, 2025
seam/client.py
Outdated
| @@ -76,3 +79,34 @@ def _handle_error_response(self, response: requests.Response): | |||
| raise SeamHttpInvalidInputError(error_details, status_code, request_id) | |||
|
|
|||
| raise SeamHttpApiError(error_details, status_code, request_id) | |||
|
|
|||
| def _is_api_error_response(self, response: requests.Response) -> bool: | |||
There was a problem hiding this comment.
If this doesn't use self it can be moved outside of the class and just be a normal internal function
Suggested change
| def _is_api_error_response(self, response: requests.Response) -> bool: | |
| def is_api_error_response(response: requests.Response) -> bool: |
There was a problem hiding this comment.
@razor-x what about using @staticmethod decorator instead?
There was a problem hiding this comment.
Similar, but staticmethod would really be for something you wanted to expose on the class. This is really just an internal private function.
There was a problem hiding this comment.
razor-x
approved these changes
Feb 12, 2025
razor-x
changed the title
andrii-balitskyi
deleted the
andrii/cx-121-handle-non-json-error-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/seam/issue/CX-121/handle-non-json-error-response