Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support generic lock devices #669

Merged
merged 4 commits into from
Jan 15, 2025
Merged

feat: support generic lock devices #669

merged 4 commits into from
Jan 15, 2025

Conversation

mikewuu
Copy link
Contributor

@mikewuu mikewuu commented Jan 15, 2025

closes #668

  • Loosen isLockDevice to check other properties that might indicate the device being a lock.
  • Add conditional UI rendering based on device online status, lock properties, access code types, etc.
  • added test in 0cf126c
  • verify fixed for client on live env

@mikewuu mikewuu merged commit 242578b into main Jan 15, 2025
18 checks passed
@mikewuu mikewuu deleted the generic-locks branch January 15, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generic devices, e.g., locks that don't have a locked property, etc.
3 participants