Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SeamEditableDeviceName to EditableDeviceName #677

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Rename SeamEditableDeviceName to EditableDeviceName #677

merged 3 commits into from
Jan 29, 2025

Conversation

razor-x
Copy link
Member

@razor-x razor-x commented Jan 29, 2025

Only public components should be under lib/seam.

  • Rename SeamEditableDeviceName to EditableDeviceName
  • Move private functions down

@razor-x razor-x requested a review from kadiryazici January 29, 2025 06:53
@razor-x razor-x marked this pull request as ready for review January 29, 2025 06:56
@razor-x razor-x enabled auto-merge (squash) January 29, 2025 06:56
@razor-x razor-x merged commit d3fd88f into main Jan 29, 2025
18 checks passed
@razor-x razor-x deleted the rename-internal-component branch January 29, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadiryazici kadiryazici kadiryazici approved these changes

@mikewuu mikewuu Awaiting requested review from mikewuu mikewuu is a code owner

@dawnho dawnho Awaiting requested review from dawnho dawnho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razor-x @kadiryazici