Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor core Ruby module API #89

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Refactor core Ruby module API #89

merged 7 commits into from
Aug 20, 2024

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Aug 9, 2024 •
edited
Loading

Closes #71

  • Rename Client to Http, use it in Seam module constructor and move factory methods to Seam
  • FIx tests
  • Allow accessing defaults with dot notation
  • Move lts_version method to Http class

@andrii-balitskyi andrii-balitskyi merged commit b3367f7 into main Aug 20, 2024
17 checks passed
@andrii-balitskyi andrii-balitskyi deleted the refactor-core-ruby-module-api branch August 20, 2024 13:52
@andrii-balitskyi andrii-balitskyi mentioned this pull request Sep 18, 2024
Merged
@andrii-balitskyi andrii-balitskyi mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razor-x razor-x razor-x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor core Ruby module API
2 participants
@andrii-balitskyi @razor-x