Try to fix flaky test

sebaslogen · Nov 19, 2023 · 3b91723 · 3b91723
1 parent 8c98f98
commit 3b91723
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/sample/src/test/java/com/sebaslogen/resacaapp/sample/ComposeActivityRecreationTests.kt b/sample/src/test/java/com/sebaslogen/resacaapp/sample/ComposeActivityRecreationTests.kt
@@ -15,8 +15,6 @@ import com.sebaslogen.resacaapp.sample.ui.main.rememberScopedDestination
 import com.sebaslogen.resacaapp.sample.ui.main.showSingleScopedViewModel
 import com.sebaslogen.resacaapp.sample.ui.main.viewModelScopedDestination
 import com.sebaslogen.resacaapp.sample.utils.ComposeTestUtils
-import kotlinx.coroutines.delay
-import kotlinx.coroutines.runBlocking
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -94,17 +92,15 @@ class ComposeActivityRecreationTests : ComposeTestUtils {
                 showSingleScopedViewModel = false // This is a fake night-mode change but it will remove Composable after Activity re-creation
                 activity.recreate()
                 printComposeUiTreeToLog()
-                runBlocking {
-                    delay(COMPOSITION_RESUMED_TIMEOUT_IN_SECONDS * 1000) // Wait for the ViewModel to be cleared
-                    printComposeUiTreeToLog() // Second print is needed to push the main thread forward
-                    val finalAmountOfViewModelsCleared = viewModelsClearedGloballySharedCounter.get()
-
-                    // Then the scoped ViewModel disappears
-                    onNodeWithTestTag("FakeInjectedViewModel Scoped", assertDisplayed = false).assertDoesNotExist()
-                    assert(finalAmountOfViewModelsCleared == initialAmountOfViewModelsCleared + 1) {
-                        "The amount of FakeInjectedViewModel that were cleared after key change ($finalAmountOfViewModelsCleared) " +
-                                "was not higher that the amount before the key change ($initialAmountOfViewModelsCleared)"
-                    }
+                Thread.sleep(COMPOSITION_RESUMED_TIMEOUT_IN_SECONDS * 1000) // Wait for the ViewModel to be cleared
+                printComposeUiTreeToLog() // Second print is needed to push the main thread forward
+                val finalAmountOfViewModelsCleared = viewModelsClearedGloballySharedCounter.get()
+
+                // Then the scoped ViewModel disappears
+                onNodeWithTestTag("FakeInjectedViewModel Scoped", assertDisplayed = false).assertDoesNotExist()
+                assert(finalAmountOfViewModelsCleared == initialAmountOfViewModelsCleared + 1) {
+                    "The amount of FakeInjectedViewModel that were cleared after key change ($finalAmountOfViewModelsCleared) " +
+                            "was not higher that the amount before the key change ($initialAmountOfViewModelsCleared)"
                 }
             }
         }

diff --git a/sample/src/test/java/com/sebaslogen/resacaapp/sample/utils/ComposeTestUtils.kt b/sample/src/test/java/com/sebaslogen/resacaapp/sample/utils/ComposeTestUtils.kt
@@ -26,13 +26,13 @@ interface ComposeTestUtils {
      */
     fun preTestInitializationToEmptyComposeDestination() {
         ComposeActivity.defaultDestination = emptyDestination
+        showSingleScopedViewModel = null
     }
 
     @Before
     @Throws(Exception::class)
     fun setUp() {
         ShadowLog.stream = System.out // Redirect Logcat to console output to read printToLog Compose debug messages
-        showSingleScopedViewModel = null
     }
 
     @After