refactor sku context and changed folder structure.
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lint ignore entries during `sku configure` (#1094)
Co-authored-by: Adam Skoufis <[email protected]>
🦋 Changeset detectedLatest commit: 93fa450 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
reviewed
Feb 12, 2025
There was a problem hiding this comment.
I've reviewed this because you'd already made the PR, and didn't want to make you do even more work than has already occurred as a result of the v14 feature branch and splitting out these changes from the vite work, but this was very difficult to review due to its size and the number of changes made.
For future reference, this should've been maybe 5+ PRs. E.g:
- Configure tsconfig paths
- Use tsconfig paths where appropriate
- Re-orgranize file structure (e.g. move things to
servicesdirectory) - General refactoring
- Sku context changes
askoufis
approved these changes
Feb 12, 2025
Co-authored-by: Adam Skoufis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skucontext to a factory function.This new context object is available on all
programactions as an option namedskuContext.libfolder items intoservicesgrouping them by their function.