Fix crash when handling uninitialized resource type #6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
kaizhangNV
added a commit
to kaizhangNV/slang
that referenced
this pull request
Feb 12, 2025
Format code for PR shader-slang#6338
kaizhangNV
force-pushed
the
uninit-resource-type
branch
from
4a7d9b4 to
2ae1d4b
Compare
|
There is a typo in the message enum "Resouce": useOfUninitializedResouceType |
kaizhangNV
force-pushed
the
uninit-resource-type
branch
2 times, most recently
from
4f8ccdd to
21c13f4
Compare
csyonghe
reviewed
Feb 12, 2025
kaizhangNV
force-pushed
the
uninit-resource-type
branch
from
21c13f4 to
a6c39ee
Compare
csyonghe
reviewed
Feb 12, 2025
kaizhangNV
force-pushed
the
uninit-resource-type
branch
from
a6c39ee to
50d8580
Compare
close shader-slang#6328. When declare a var with struct type, if the struct has a resource type field and it doesn't provide explicit constructor, because slang won't implicit construct such variable at declare site if user doesn't explicitly call the initializer list, we should report the resource type field uninitialized as an error to prevent future possible crash when legalize any use of such variable.
kaizhangNV
force-pushed
the
uninit-resource-type
branch
from
50d8580 to
b7f8771
Compare
kaizhangNV
force-pushed
the
uninit-resource-type
branch
from
b7f8771 to
75ecbb7
Compare
csyonghe
previously approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6328.
When declare a var with struct type, if the struct has a resource type field and it doesn't provide explicit constructor, because slang won't implicit construct such variable at declare site if user doesn't explicitly call the initializer list, we should report the resource type field uninitialized as an error to prevent future possible crash when legalize any use of such variable.