Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Avoid docker containers in favor of prebuilt binaries #83

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

FreezyLemon
Copy link
Contributor

Reasoning: See jrottenberg/ffmpeg#410 and the PR linked there. TL;DR: An update to the docker images (which was done from a PR branch, not documented and can't be found anywhere on main) broke our CI & the one response I have gotten has not been reassuring.

Since the problem is effectively a showstopper for this repo, let's switch to something that shouldn't break so easily, even if it's a bit more work to set up initially.

Changes:

  • Replace jrottenberg/ffmpeg docker container with prebuilt binaries from https://github.com/wang-bin/avbuild
    • This needs a bit of patching due to an issue in the pkgconfig files
    • otherwise, just extract to some directory and then set PKG_CONFIG_PATH for compile time and LD_LIBRARY_PATH for runtime
  • Remove 5.0 and 6.0 from CI as they are EOL upstream
  • Adjust a few tests that relied on the external libraries included in FFmpeg

@shssoichiro shssoichiro merged commit 5834596 into shssoichiro:master Nov 4, 2024
20 checks passed
@FreezyLemon FreezyLemon deleted the ci-use-wang-bin-avbuild branch November 4, 2024 17:31
@FreezyLemon
Copy link
Contributor Author

Thankfully, this didn't uncover any bugs in the previous PRs :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants