-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --client-signing-algorithms flag #1974
base: main
Are you sure you want to change the base?
Added --client-signing-algorithms flag #1974
Conversation
ee1f9ae
to
be96ecd
Compare
be96ecd
to
b450afb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
===========================================
- Coverage 66.46% 41.78% -24.68%
===========================================
Files 92 192 +100
Lines 9258 24857 +15599
===========================================
+ Hits 6153 10387 +4234
- Misses 2359 13695 +11336
- Partials 746 775 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bffe52e
to
55f01c3
Compare
Apparently the e2e test does not fill the Signature part of the JARModel: if v.JARModel.Signature == nil || v.JARModel.Signature.PublicKey == nil || v.JARModel.Signature.PublicKey.Content == nil {
return nil, errors.New("jar v0.0.1 entry not initialized")
} Shall this be handled or is the signature always expected to be present? |
Signature should be present, it's required to validate a new jar entry - rekor/pkg/types/jar/v0.0.1/entry.go Line 248 in d596e9d
|
go.mod
Outdated
@@ -204,3 +204,5 @@ require ( | |||
gopkg.in/yaml.v2 v2.4.0 | |||
gopkg.in/yaml.v3 v3.0.1 // indirect | |||
) | |||
|
|||
replace github.com/sigstore/sigstore => github.com/trail-of-forks/sigstore v0.0.0-20240219090738-536a0415e570 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs removed before merge
2ac074e
to
34f31c3
Compare
Signed-off-by: Riccardo Schirone <[email protected]>
808f8d9
to
c31e028
Compare
Summary
Add
--client-signing-algorithms
flag to rekor-server to restrict the set of client keys accepted by a Rekor instance. See #1724 .This work depends on sigstore/sigstore#1601
Release Note
Documentation