feat(outputters): Add a method to handle empty PDFs vs. cleanup after…

… error
sile-typesetter · Dec 12, 2024 · 7f942df · 7f942df
1 parent 9df32f1
commit 7f942df
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/core/utilities/init.lua b/core/utilities/init.lua
@@ -332,7 +332,7 @@ function utilities.error (message, isbug)
    utilities.warn(message, isbug)
    _skip_traceback_levels = 2
    io.stderr:flush()
-   SILE.outputter:finish() -- Only really useful from the REPL but no harm in trying
+   SILE.outputter:abort()
    SILE.scratch.caughterror = true
    error("", 2)
 end

diff --git a/outputters/base.lua b/outputters/base.lua
@@ -29,6 +29,8 @@ end
 
 function outputter.newPage () end
 
+function outputter:abort () end
+
 function outputter:finish ()
    self:runHooks("prefinish")
 end

diff --git a/outputters/libtexpdf.lua b/outputters/libtexpdf.lua
@@ -67,13 +67,23 @@ end
 -- pdf structure package needs a tie in here
 function outputter._endHook (_) end
 
+function outputter:abort ()
+   if started then
+      pdf.endpage()
+      pdf.finish()
+      started = false
+      lastkey = false
+   end
+end
+
 function outputter:finish ()
+   -- allows generation of empty PDFs
    self:_ensureInit()
    pdf.endpage()
    self:runHooks("prefinish")
    pdf.finish()
    started = false
-   lastkey = nil
+   lastkey = false
 end
 
 function outputter.getCursor (_)