Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of legacy \script function with non-modules #2206

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

alerque
Copy link
Member

@alerque alerque commented Jan 2, 2025

The current implementation assumes that a table is returned. I checks to see if that table is a proper SILE module, but it doesn't stop to think what happens if just a function, string, or other data is returned.

@alerque alerque added this to the v0.15.9 milestone Jan 2, 2025
@alerque
Copy link
Member Author

alerque commented Jan 2, 2025

Test failure in LuaJIT run is this shenanigans.

@alerque alerque merged commit 8aa8c3c into sile-typesetter:master Jan 2, 2025
16 of 22 checks passed
@alerque alerque deleted the legacy-use branch January 2, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant