-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vertx.version from 4.1.5 to 4.2.0 #124
Conversation
Bumps `vertx.version` from 4.1.5 to 4.2.0. Updates `vertx-consul-client` from 4.1.5 to 4.2.0 Updates `vertx-core` from 4.1.5 to 4.2.0 - [Release notes](https://github.com/eclipse/vert.x/releases) - [Commits](eclipse-vertx/vert.x@4.1.5...4.2.0) --- updated-dependencies: - dependency-name: io.vertx:vertx-consul-client dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.vertx:vertx-core dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
e16552e
to
e89df43
Compare
@cescoffier I'm guessing we should rather stick to 4.1 to be aligned with Quarkus, WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tried with 4.2.0
and the java 17 problem is still there
I created a PR to fix it there but it isn't merged yet |
Do not update to 4.2 yet. Stork is now part of the ultimate Vert.x update choreography, an explosive mix of sensitivity and risk... I will proceed to the update next week or the week after. I'm still thinking about whether we should target 2.5 or 2.6. |
@dependabot ignore this major version |
OK, I won't notify you about version 4.x.x again, unless you re-open this PR or update to a 4.x.x release yourself. |
oops, I wanted @dependabot ignore this minor version :D |
We will need a Vert.x 4.2.1 with the fix. The workaround (declaring the dependency on Vert.x Web Client) is possible, but you still have the warning in the log. |
also, 4.2.0 doesn't include vert-x3/vertx-consul-client#85 so it fails with java 17 |
Bumps
vertx.version
from 4.1.5 to 4.2.0.Updates
vertx-consul-client
from 4.1.5 to 4.2.0Updates
vertx-core
from 4.1.5 to 4.2.0Commits
a234731
Releasing 4.2.0fbd6fba
Fix incorrect pom7e9a31f
Improve finding maven target dir in tests08f07b4
Fix extra compiler phases when not executed correctly by Maven from a locatio...b7928a4
Improve ServiceHelperTestdb525b5
Fix incorrect testbb3ab4d
Regen code1c775bf
Explicitly mention that Vert.x supports Java from 8 to 17 and remove jetty-al...65f51c6
Move static ByteBuf allocator instances to VertxByteBufAllocator instead of V...b2f3ec1
We don't need to keep a reference to the ServerID in TCPServerBase and we can...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)