Expose initialiseWith* functions on react-native

[JNdhlovu]

Story: https://app.shortcut.com/smileid/story/14700/expose-initialisewith-functions-on-react-native

Summary

So far, the react-native sdk doesn't expose the initializeWithApiKey and initializeWithConfig function in the SmileID object. The underlying ios and android implementation already have those functions exposed, we're just missing to expose them in the SmileID object.

Known Issues

• I've not been able to test this on XCode 16

Test Instructions

• Inititalize using the config.json which is the existing method and run a job
• Initialize with api key and run a job
• Initialize with the config.json object

Screenshot

N/A

[prfectionist]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns API Key Exposure: The new initializeWithApiKey function accepts an API key parameter. Need to ensure this API key is properly secured and not logged or exposed in any way during initialization.

⚡ Recommended focus areas for review Parameter Validation The new initialization functions don't validate input parameters. Should check for null/undefined values and validate config object structure. Documentation The new initialization functions lack JSDoc documentation about parameters and usage, unlike the existing initialize function.

[prfectionist]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add input validation to prevent runtime errors from invalid parameters Add parameter validation to ensure apiKey is not empty or undefined before passing it to the native module. src/index.tsx [72-83] initializeWithApiKey: ( apiKey: string, config: Config, useSandBox: boolean, enableCrashReporting: boolean -) => - _SmileID.initializeWithApiKey( +) => { + if (!apiKey?.trim()) { + throw new Error('API key cannot be empty'); + } + return _SmileID.initializeWithApiKey( apiKey, config, useSandBox, enableCrashReporting - ), + ); +}, Suggestion importance[1-10]: 8 Why: Adding validation for the API key is crucial for preventing runtime errors and providing clear error messages, especially since this is an initialization method where the API key is a critical parameter.	8
Enhancement	Add default parameter values to improve API usability and consistency Add default values for useSandBox and enableCrashReporting parameters to maintain consistency with the existing initialize method and provide sensible defaults. src/index.tsx [72-77] initializeWithApiKey: ( apiKey: string, config: Config, - useSandBox: boolean, - enableCrashReporting: boolean + useSandBox: boolean = false, + enableCrashReporting: boolean = true ) Suggestion importance[1-10]: 7 Why: Adding default values for parameters would maintain consistency with the existing initialize method and improve developer experience by reducing required parameters. This aligns with the existing pattern shown in line 70.	7

[robin-ankele]

@JNdhlovu, @jumaallan I've noticed that the following params in the config object differ between android and iOS:

• iOS: prodLambdaUrl, testLambdaUrl
• Android: prodBaseUrl, sandboxBaseUrl

Does is make sense to change the Mapper for android to grab the keys as defined in

react-native/src/types.ts

Line 9 in a96bb70

prodLambdaUrl: string;

and map to the android definitions:

react-native/android/src/main/java/com/smileidentity/react/Mapper.kt

Line 34 in a96bb70

prodBaseUrl = getStringOrDefault("prodBaseUrl") ?: run {

react-native/android/src/main/java/com/smileidentity/react/Mapper.kt

Line 37 in a96bb70

sandboxBaseUrl = getStringOrDefault("sandboxBaseUrl") ?: run {

[robin-ankele]

Tested on iOS and android side. Works fine. Left a comment on the Config object.

[tobitech]

I was able to test this on iOS. Tested Selfie Capture, Biometric KYC and Document Verification.

[robin-ankele]

As discussed in slack, should we add a section to the README to talk about the new initalisation params for partners to fill in?

[robin-ankele]

Works fine on android and iOS. I've tested the following configurations:

• SmileID.initialize(false, false, config) // with config
• SmileID.initialize(false) // with config.json file
  @JNdhlovu can we update https://docs.usesmileid.com/integration-options/mobile/getting-started to reflect the change that the enableCrashReporting is the 2nd parameter?