fix: make proposition power query reactive on enabled flag #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum, I can't see any difference in behavior from current deployed UI version |
|
Are you testing with ArgentX |
|
On snapshot.box, logged in with ArgentX: https://snapshot.box/#/sn:0x059421b887fb3b7102653763f7ce8896c5976dc536be26502fd8ed71e87a239e/create/f665o Screen.Recording.2025-02-12.at.20.53.47.movWith this PR: Screen.Recording.2025-02-12.at.20.55.39.mov |
|
I can not reproduce either. On master, the publish button is in the expected state after refresh (grey when no propositon power, enabled otherwise if title is filled) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously proposition query wasn't enabled reactively. If I refresh editor page with ArgentX it would end up as always pending (with submit button loading).
Additionally handled case where it would before show as Publish button, then loading indicator and Publish button again as it wouldn't show loading indicator if there was no account (and it might be on refresh) by extracting it into new computed value and showing loading indicator if auth is loading.
How to test