Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure space is fetched if it has unnamed children #1185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Feb 13, 2025

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/450

This is because ranking query in explore page doesn't return children data except name, adding children data to query can slow down explore page, better alternative is to fetch space if some children doesn't have a name

How to test

  1. Go to explore page
  2. Click on a space with children (example stakedao.eth)
  3. It should show children names

@ChaituVR ChaituVR requested a review from wa0x6e February 13, 2025 17:27
@bonustrack
Copy link
Member

With this solution, sub spaces appear first without name, then name appear. A better behavior would be to show space only once we can display all the content.

@ChaituVR
Copy link
Member Author

With this solution, sub spaces appear first without name, then name appear. A better behavior would be to show space only once we can display all the content.

We could hide subspaces if they don't have a name and show them once they load?

It looks like it is same case if a space have a parent

@wa0x6e
Copy link
Contributor

wa0x6e commented Feb 14, 2025

With this solution, sub spaces appear first without name, then name appear. A better behavior would be to show space only once we can display all the content.

We could hide subspaces if they don't have a name and show them once they load?

It looks like it is same case if a space have a parent

Better UX would be to show a skeleton loading (https://flowbite.com/docs/components/skeleton/), or just our current loading icon for the whole subspace card if info are not complete.

Hiding and show elements later will move content of the page, and is bad UX

@bonustrack
Copy link
Member

Let's not do skeleton yet, we don't have skeleton anywhere in the site

@wa0x6e
Copy link
Contributor

wa0x6e commented Feb 15, 2025

So, simple loading icon in place of the missing title, or the entire card (possible, since the card has a fixed height) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants