refactor: use vue-queries for spaces #1191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary approach so we can delete spaces store/composable soon. In the future we should refactor followedSpaces store to use vue-query as well.
Sekhmet
force-pushed
the
sekhmet/spaces-queries
branch
from
d0bb033 to
a7e8746
Compare
Sekhmet
commented
Feb 14, 2025
Comment on lines
+16
to
+19
| const spaceIdComposite = computed( | ||
| () => `${props.space.network}:${props.space.id}` | ||
| ); | ||
|
|
There was a problem hiding this comment.
It used to work before because in our case space was reactive object under the hood.
Sekhmet
commented
Feb 14, 2025
| @@ -72,10 +72,10 @@ watchThrottled( | |||
| ); | |||
|
|
|||
| watch( | |||
| [props.space, state, labels], | |||
| ([toSpace, toState, toLabels], [fromSpace, fromState, fromLabels]) => { | |||
| [() => props.space.id, state, labels], | |||
There was a problem hiding this comment.
Here it used to work as well, because props.space was reactive, regular props cannot be used as watch source.
|
Works well, except on the left sidebar with list of following space avatar, this section blink when I come from the home page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is resubmit of #1155 (it was reverted after merge) with couple of bug fixes (some issues were fixed in the PR this PR depends on).
Some issues that should be resolved now were caused by the fact that we in some places misused reactivity, which worked with reactive objects (which Spaces used to be), but taking away that implicit reactivity broke it, so we should give this PR proper testing to make sure we are not missing anything.
Depends on #1190
This PR refactors spaces fetching to use vue-query. This removes complex code of spaces composable solving some issues we had before (quickly switching filters for spaces shouldn't break it - only data matching current selection should be visible).
Some things are not handled 100% the way they should (followedSpaces, User profile), because they need refactor of its own. This is already quite big PR so I took some shortcuts there.
Towards https://github.com/snapshot-labs/workflow/issues/410
How to test