Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dependencies): migrate to @yao-pkg/pkg #5554

Merged
merged 2 commits into from
Jan 28, 2025
Merged

chore(dependencies): migrate to @yao-pkg/pkg #5554

merged 2 commits into from
Jan 28, 2025

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Oct 25, 2024 •
edited
Loading

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Switches from the deprecated pkg to the community fork @yao-pkg/pkg, this is the latest version in the 5.x.x release and intended to be a drop in replacement for the original pkg implementation.

Why?

  • pkg is deprecated so we should remove it from our list of dependencies
  • Node v18 reaches EOL on April 30th. pkg does not support versions of node higher than 18, so we need to switch tooling before we can make that upgrade in a future PR.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Warnings
⚠️ There are multiple commits on your branch, please squash them locally before merging!

Generated by 🚫 dangerJS against 2f3a9c4

@thisislawatts thisislawatts force-pushed the spike/migrate-to-yao-pkg branch 2 times, most recently from 3f956f4 to 6b5863f Compare November 25, 2024 08:54
@thisislawatts thisislawatts force-pushed the spike/migrate-to-yao-pkg branch 3 times, most recently from ba57d93 to 1c2c2b0 Compare January 13, 2025 12:56
@thisislawatts thisislawatts force-pushed the spike/migrate-to-yao-pkg branch 3 times, most recently from 60d758f to 2977f05 Compare January 14, 2025 06:32
@thisislawatts thisislawatts changed the title chore(dependencies): migrate to yao pkg chore(dependencies): migrate to @yao/pkg Jan 14, 2025
@thisislawatts thisislawatts changed the title chore(dependencies): migrate to @yao/pkg chore(dependencies): migrate to @yao-pkg/pkg Jan 14, 2025
@thisislawatts thisislawatts force-pushed the spike/migrate-to-yao-pkg branch from 2977f05 to ac22bdf Compare January 23, 2025 19:10
@thisislawatts thisislawatts marked this pull request as ready for review January 23, 2025 19:17
@thisislawatts thisislawatts requested a review from a team as a code owner January 23, 2025 19:17
@PeterSchafer
Copy link
Collaborator

Nice!

@thisislawatts thisislawatts force-pushed the spike/migrate-to-yao-pkg branch from ac22bdf to 517737c Compare January 24, 2025 16:02
@thisislawatts thisislawatts force-pushed the spike/migrate-to-yao-pkg branch from 517737c to 2f3a9c4 Compare January 28, 2025 08:28
@thisislawatts thisislawatts merged commit c03030d into main Jan 28, 2025
7 checks passed
@thisislawatts thisislawatts deleted the spike/migrate-to-yao-pkg branch January 28, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatalinSnyk CatalinSnyk CatalinSnyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisislawatts @PeterSchafer @CatalinSnyk