Store plugins in the Crate structure #209
Conversation
integraledelebesgue
requested review from
Arcticae and
Draggu
and removed request for
a team
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
eb2d8ce to
659c827
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
5a57025 to
9942c29
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
659c827 to
a1a6506
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
3 times, most recently
from
b7e504f to
456121c
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
639396f to
98cc352
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
456121c to
29698c0
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
98cc352 to
321bd50
Compare
| acc | ||
| }); | ||
|
|
||
| debug!("Plugins for {}: {:#?}", package.unwrap().id.repr, plugins); |
There was a problem hiding this comment.
Crates are all logged to debug here
Line 95 in 7e357b3
There was a problem hiding this comment.
This message is for debugging purposes. I added a comment to remind me to delete it before merging
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
29698c0 to
ff0fc4d
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
321bd50 to
c43464a
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
ff0fc4d to
8364856
Compare
integraledelebesgue
force-pushed
the
spr/main/fa144cb1
branch
from
c43464a to
c161fce
Compare
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
8364856 to
67150c9
Compare
commit-id:988401af
integraledelebesgue
force-pushed
the
spr/main/988401af
branch
from
67150c9 to
2a85ae2
Compare
| /// Plugins required by the crate. | ||
| #[allow(dead_code)] // TODO: remove. The field is used later in the stack | ||
| pub plugins: PluginSuite, |
There was a problem hiding this comment.
| /// Plugins required by the crate. | |
| #[allow(dead_code)] // TODO: remove. The field is used later in the stack | |
| pub plugins: PluginSuite, | |
| /// Built-in plugins required by the crate. | |
| #[allow(dead_code)] // TODO: remove. The field is used later in the stack | |
| pub built_in_plugins: PluginSuite, |
| use cairo_lang_utils::{Intern, LookupIntern}; | ||
| use smol_str::SmolStr; | ||
|
|
||
| use crate::lang::db::AnalysisDatabase; | ||
|
|
||
| /// A complete set of information needed to set up a real crate in the analysis database. | ||
| #[derive(Debug, PartialEq, Eq)] | ||
| #[derive(Debug)] |
There was a problem hiding this comment.
I would like to preserve the plain nature of this struct. I know we're not based on upstream changes to the compiler yet here, but do you think if it would be possible to keep just a set of plugin ids here?
There was a problem hiding this comment.
You don't have plugin ids in this PR at all since they are never interned, only treated as an input
There was a problem hiding this comment.
Storing IDs in Crate seems possible when we start using the new compiler API, but it would require passing a database to extract_crates, which can be tricky
There was a problem hiding this comment.
@piotmag769 is right. we would need to have a custom ID mechanism (PackageIDs I guess) at this stage. nonetheless, this is a separate piece of work which is not needed urgently right now
Stack: