fix: useAnimatedProps on input component not working on web
#6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Thanks for the PR! LGTM, but let's wait for @piaskowyk's approval prior to merging.
packages/react-native-reanimated/src/ReanimatedModule/js-reanimated/index.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomek Zawadzki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6202.
Due to React Native's
_valueTracker, usinguseAnimatedPropswon't work on input component. Before when usingreact-native-web<= 18 we were able to settextprops usingsetNativePropslegacy function. Currently on newerreact-native-web, (and due to the_valueTracker), we were trying tosetAttributetexton input component -unsuccessfully.This PR implements fix that checks whether current component is
inputwith a proptext, if so it updates props directly on it.With a support from this PR.
Test plan
Run JS props or Amount in
web-example