Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scarb prove #1900

Merged
merged 75 commits into from
Jan 31, 2025
Merged

Add scarb prove #1900

merged 75 commits into from
Jan 31, 2025
+1,423 −193

Conversation

DelevoXDG
Copy link
Contributor

@DelevoXDG DelevoXDG commented Jan 18, 2025 •
edited
Loading

  • Adds scarb verify
  • Updates scarb execute output paths
    • All execution outputs are now placed in [..]/target/execute/package_name/execution{i} where i = 1...N
    • Cairo pie outputs are now placed in [..]/target/execute/package_name/execution{i}/cairo_pie.zip

Stack

FroyaTheHen and others added 22 commits January 15, 2025 08:53
@FroyaTheHen @maciektr
feat: executable command
c658194 
Add scarb execute extension
@DelevoXDG
Initial cairo-prove
af5414d
@DelevoXDG
Support prover config; Restructure args
ccc3aa3
@DelevoXDG
Restructure cairo-execute output directories
972acdd 
Change output path from `scarb-execute/package_N` to `scarb-execute/package/executionN`
@DelevoXDG
Refactor; Improve error messages; Improve args
6036329
@DelevoXDG
Add tests
0a404e4
@DelevoXDG
Refactor
55525ed
@DelevoXDG
Format
0da153d
@DelevoXDG
Add --execute flag to run execution before prove
cb4b7fb
@DelevoXDG
Refactor: add helper functions; Simplify execution_number extractio…
3946387 
…n logic
@DelevoXDG
Improve error messages in line with scarb execute changes
951e3d7
@DelevoXDG
use lossy utf8 conversion
ff83e91
@DelevoXDG
misc: rename test
3c31623
@DelevoXDG
rename all "execution number" mentions to execution_id
5bb3424
@DelevoXDG
Add verbosity settings
01070f1
@DelevoXDG
fix tests (--execution-id)
e02f52d
@DelevoXDG
Disable scarb execute output for quiet verbosity
e82596a
@DelevoXDG
Stream AND write output of subcommand on the fly
39f1f70
@DelevoXDG
Format
de0d76d
@DelevoXDG
improve approach to streaming stdout of nested commands
72e223b 
- Add `UiPrinter`
- Cannot use `Ui` directly due to circular dependency
@DelevoXDG
refactor: rename scarb-cairo-{execute,prove} to scarb-{execute,prove}
2ab30cd
@DelevoXDG
finish scarb-cairo-{execute,prove} -> scarb-{execute,prove}`
e6556de
@DelevoXDG DelevoXDG changed the base branch from maicektr/executable to main January 18, 2025 05:05
@DelevoXDG DelevoXDG changed the title Zdobnikau/stwo prove Add scarb prove Jan 18, 2025
@DelevoXDG DelevoXDG mentioned this pull request Jan 28, 2025
Open
maciektr
maciektr reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only styling comments attached

extensions/scarb-prove/src/main.rs Show resolved Hide resolved
extensions/scarb-prove/src/main.rs Outdated Show resolved Hide resolved
extensions/scarb-prove/src/main.rs Outdated Show resolved Hide resolved
extensions/scarb-prove/src/main.rs Outdated Show resolved Hide resolved
extensions/scarb-prove/src/main.rs Outdated Show resolved Hide resolved
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
@DelevoXDG
Split scarb-execute into subfiles (#1924)
f2a53fc 
## Stack
- #1924
- #1900
- #1922 

To expose args and `main_inner` so these are usable by scarb-prove
Base automatically changed from zdobnikau/split-execute to main January 31, 2025 10:11
maciektr
maciektr approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good to me!

@DelevoXDG DelevoXDG enabled auto-merge January 31, 2025 16:16
@DelevoXDG DelevoXDG added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@maciektr maciektr added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 447d7d0 Jan 31, 2025
22 checks passed
@maciektr maciektr deleted the zdobnikau/stwo-prove branch January 31, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

@THenry14 THenry14 Awaiting requested review from THenry14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DelevoXDG @THenry14 @maciektr @FroyaTheHen