Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between library and plugin IDs in component dependencies #1912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Distinguish between library and plugin IDs in component dependencies #1912

wants to merge 1 commit into from
+53 −19

Conversation

integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Jan 22, 2025 •
edited
Loading

@integraledelebesgue integraledelebesgue requested a review from a team as a code owner January 22, 2025 11:18
This was referenced Jan 22, 2025
Open
Open
Open
This was referenced Jan 27, 2025
Open
Open
Open
maciektr
maciektr requested changes Jan 28, 2025
View reviewed changes
scarb/src/compiler/compilation_unit.rs Outdated Show resolved Hide resolved
piotmag769
piotmag769 approved these changes Jan 29, 2025
View reviewed changes
scarb/src/compiler/compilation_unit.rs
Comment on lines +98 to +102
/// Checks whether the [`CompilationUnitComponent`] represents a plugin package.
pub fn is_cairo_plugin(&self) -> bool {
self.package.is_cairo_plugin()
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can component ever be a plugin? cc @maciektr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose components representing procedural macros will return true here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, @maciektr suggested adding this function (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr requested changes

@Draggu Draggu Draggu approved these changes

@piotmag769 piotmag769 piotmag769 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@integraledelebesgue @maciektr @piotmag769 @Draggu