e2e: introduce optional shard cache #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While iterating on the ranking tests it is frustrating to wait for the index to be built. This commit adds a "-shard_cache" flag to reuse the computed shards. It defaults to off since this could lead to unexpected results if we change how we index. Test Plan: run go test several times with the flag, only the first run should be slow. Then confirm without flag it is "slow". $ go test -shard_cache PASS ok github.com/sourcegraph/zoekt/internal/e2e 23.307s $ go test -shard_cache PASS ok github.com/sourcegraph/zoekt/internal/e2e 0.235s $ go test -shard_cache PASS ok github.com/sourcegraph/zoekt/internal/e2e 0.218s $ go test PASS ok github.com/sourcegraph/zoekt/internal/e2e 23.416s
stefanhengl
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While iterating on the ranking tests it is frustrating to wait for the index to be built. This commit adds a "-shard_cache" flag to reuse the computed shards. It defaults to off since this could lead to unexpected results if we change how we index.
This is another take on #697
Test Plan: run go test several times with the flag, only the first run should be slow. Then confirm without flag it is "slow".