Add a UTC date to the marker document and venv/ to the .gitignore #3033
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptindall
requested review from
dlstadther,
honnix and
Tarrasch
as code owners
honnix
reviewed
Feb 10, 2021
| """ | ||
| self.create_marker_index() | ||
| self.es.index(index=self.marker_index, doc_type=self.marker_doc_type, | ||
| id=self.marker_index_document_id(), body={ | ||
| 'update_id': self.update_id, | ||
| 'target_index': self.index, | ||
| 'target_doc_type': self.doc_type, | ||
| 'date': datetime.datetime.now()}) | ||
| 'date': datetime.datetime.now(), | ||
| 'date_utc': datetime.datetime.utcnow()}) |
There was a problem hiding this comment.
Not an expert of ES, so not sure of the impact here.
| @@ -169,15 +169,18 @@ def touch(self): | |||
|
|
|||
| The document id would be sufficient but, | |||
| for documentation, | |||
| we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well. | |||
| we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well. `date_utc` added | |||
There was a problem hiding this comment.
I think the added comment fits better as a PR comment instead of docstring to track the reasoning. Maybe something as simple as: we index the parameters update_id, target_index, target_doc_type , date and date_utc.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an additional field to the marker entry for the ElasticSearch target so we also have the UTC based date.
I also use PyCharm which sets up the local virtual as
venv/so I wanted to be sure that was ignored as part of .gitignoreMotivation and Context
We use UTC dates to control incremental processes and knowing when this marker was last updated based upon a UTC
date is needed for us.
Have you tested this? If so, how?
I have run "tox -e py39-core test/contrib/esindex_test.py" locally on this change.