Fix Windows compile issues #67
Conversation
Fixes applied based on discussions here: src-d#61 mkleehammer/pyodbc#663 Signed-off-by: Scott <[email protected]>
| long l=PyLong_AsLong(cache_obj); | ||
| cache = reinterpret_cast<C *>(reinterpret_cast<intptr_t>( &l )); |
There was a problem hiding this comment.
This is no good: instead of converting an integer to a cache pointer you pretend that a local variable's address is a cache pointer. The size of long on Windows equals to 4 bytes while the pointer size is 8 bytes. Can you please replace PyLong_AsLong with PyLong_AsLongLong here?
| long l=PyLong_AsLong(cache_obj); | |
| cache = reinterpret_cast<C *>(reinterpret_cast<intptr_t>( &l )); | |
| cache = reinterpret_cast<C *>(reinterpret_cast<intptr_t>( | |
| PyLong_AsLongLong(cache_obj))); |
There was a problem hiding this comment.
I am unable to get this to work. I continue to get python.cc(152): error C2440: 'reinterpret_cast': cannot convert from '__int64' to 'intptr_t'
There was a problem hiding this comment.
I changed reinterpret_cast<intptr_t>(PyLong_AsLongLong(cache_obj)) to reinterpret_cast<intptr_t *>(PyLong_AsLongLong(cache_obj)) and it compiled successfully, I'm not exactly sure about the implications of that, though.
Co-Authored-By: Vadim Markovtsev <[email protected]>
Co-Authored-By: Vadim Markovtsev <[email protected]>
Fixes applied based on discussions here:
#61
mkleehammer/pyodbc#663
Please test to make sure the changes to python.cc work on Linux.