Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stac-geoparquet reading and writing #1521

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 7, 2025

Related Issue(s):

Description:

  • Add stacrs as an optional dependency and use it to read and write item collections
  • I initially thought about embedding it into StacIO but that felt too impactful, since we're just doing ItemCollections for now
  • It's a little awkward since stacrs is async, so we may want to refactor some stuff out to helper functions if we end up using it other places

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell February 7, 2025 17:52
@gadomski gadomski self-assigned this Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.44%. Comparing base (542b9fb) to head (8984e84).

Files with missing lines Patch % Lines
pystac/item_collection.py 71.42% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1521      +/-   ##
==========================================
- Coverage   91.47%   91.44%   -0.04%     
==========================================
  Files          54       54              
  Lines        7542     7560      +18     
  Branches      915      917       +2     
==========================================
+ Hits         6899     6913      +14     
- Misses        457      459       +2     
- Partials      186      188       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsignell jsignell mentioned this pull request Feb 7, 2025
5 tasks
@gadomski gadomski marked this pull request as draft February 7, 2025 19:13
@gadomski
Copy link
Member Author

gadomski commented Feb 7, 2025

Marking as draft while I dig into some PyPI size restrictions that are keeping me from releasing Windoze wheels that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use stacrs to read+write stac-geoparquet
1 participant