test: improve readablity of test_validate_accounts_tx (#1834)

starkware-libs · Apr 30, 2024 · 6b87bdc · 6b87bdc
1 parent 12820a2
commit 6b87bdc
Showing 1 changed file with 10 additions and 15 deletions.
diff --git a/crates/blockifier/src/transaction/transactions_test.rs b/crates/blockifier/src/transaction/transactions_test.rs
@@ -1522,9 +1522,8 @@ fn test_validate_accounts_tx(
             ..default_args
         },
     );
-    account_tx
-        .execute(state, block_context, true, true)
-        .unwrap_or_else(|err| panic!("Execution failed: {:?}", err));
+    let result = account_tx.execute(state, block_context, true, true);
+    assert!(result.is_ok(), "Execution failed: {:?}", result.unwrap_err());
 
     if tx_type != TransactionType::DeployAccount {
         // Call self (allowed).
@@ -1536,9 +1535,8 @@ fn test_validate_accounts_tx(
                 ..default_args
             },
         );
-        account_tx
-            .execute(state, block_context, true, true)
-            .unwrap_or_else(|err| panic!("Execution failed: {:?}", err));
+        let result = account_tx.execute(state, block_context, true, true);
+        assert!(result.is_ok(), "Execution failed: {:?}", result.unwrap_err());
     }
 
     if let CairoVersion::Cairo0 = cairo_version {
@@ -1553,9 +1551,8 @@ fn test_validate_accounts_tx(
                 ..default_args
             },
         );
-        account_tx
-            .execute(state, block_context, true, true)
-            .unwrap_or_else(|err| panic!("Execution failed: {:?}", err));
+        let result = account_tx.execute(state, block_context, true, true);
+        assert!(result.is_ok(), "Execution failed: {:?}", result.unwrap_err());
 
         // Call the syscall get_block_timestamp and assert the returned timestamp was modified
         // for validate.
@@ -1568,9 +1565,8 @@ fn test_validate_accounts_tx(
                 ..default_args
             },
         );
-        account_tx
-            .execute(state, block_context, true, true)
-            .unwrap_or_else(|err| panic!("Execution failed: {:?}", err));
+        let result = account_tx.execute(state, block_context, true, true);
+        assert!(result.is_ok(), "Execution failed: {:?}", result.unwrap_err());
     }
 
     if let CairoVersion::Cairo1 = cairo_version {
@@ -1589,9 +1585,8 @@ fn test_validate_accounts_tx(
                 ..default_args
             },
         );
-        account_tx
-            .execute(state, block_context, true, true)
-            .unwrap_or_else(|err| panic!("Execution failed: {:?}", err));
+        let result = account_tx.execute(state, block_context, true, true);
+        assert!(result.is_ok(), "Execution failed: {:?}", result.unwrap_err());
     }
 }