move private features to build.rs #710
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
build-rs
branch
2 times, most recently
from
2feec2f to
a7ecd01
Compare
therealprof
reviewed
Dec 9, 2023
Cargo.toml
Outdated
|
|
||
| [[example]] | ||
| name = "f413disco-lcd-ferris" | ||
| required-features = ["gpiod", "gpioe", "gpiof", "gpiog", "fsmc", "fsmc_lcd"] # stm32f413 | ||
| required-features = ["stm32f413", "fsmc_lcd"] |
There was a problem hiding this comment.
I was kind of hoping we would go the other way around and make them less MCU model dependent? Not really a big fan of declaring that this only works on stm32f413... Same for the others of course.
There was a problem hiding this comment.
Good point. But I don't have good answer.
Do you have ideas?
There was a problem hiding this comment.
Not really, except that this is going in the wrong direction. Not quite sure how we can accomplish more genericity with the build.rs idea.
burrbull
force-pushed
the
build-rs
branch
3 times, most recently
from
8e20c08 to
5d294f1
Compare
burrbull
force-pushed
the
build-rs
branch
4 times, most recently
from
1fd9678 to
aeb6764
Compare
burrbull
commented
Jun 12, 2024
| uart9 = [] | ||
| uart10 = [] | ||
| # Private features for testing only | ||
| _pac_fsmc = [] |
There was a problem hiding this comment.
@therealprof
I could not find any other solution for examples except fictive features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.