Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly look for sibling elements inside blocks and components #15106

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented Jan 24, 2025

Fixes #15027 and fixes #14995

When the target element is inside a block or component, get_following_sibling_elements was looking only for sibling elements after the block/component. This PR fixes it by starting the search from the begging of the block/component and skipping nodes that go before the target element.

Also, I noticed that selector like .elem:has(+ .not-adjacent-sibling) isn't marked as unused. Example. Though, it's false negative and isn't that bad.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 385b6f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

.changeset/curly-balloons-relate.md Outdated Show resolved Hide resolved
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15106

@dummdidumm dummdidumm merged commit 9410ad0 into sveltejs:main Jan 29, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
@7nik 7nik deleted the fix-has-selector-in-blocks branch January 29, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants