Skip to content

Commit

Permalink
fix: add explicit ascent override on nimbus sans typeface
Browse files Browse the repository at this point in the history
  • Loading branch information
SethFalco committed May 19, 2024
1 parent a48e5a7 commit ab6e3e0
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/components/SvgoPreview/index.module.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.profit {
font-family: var(--svgo-font-mono);
font-family: var(--ifm-font-family-monospace);
}

.highlight {
Expand Down
8 changes: 2 additions & 6 deletions src/css/custom.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
:root {
--svgo-font-mono: 'Liberation Mono', Monaco, Cousine, Consolas, monospace;

This comment has been minimized.

Copy link
@SethFalco

SethFalco May 19, 2024

Author Member

Ahh, I forgot to amend the commit message for this when I changed my approach to resolving the issue.

The commit message does not reflect what this change does. Please see the PR associated with it for more information:

--svgo-font-sans: 'Nimbus Sans', Helvetica, Arial, Roboto, 'Liberation Sans', 'DejaVu Sans', Arimo, sans-serif;
--svgo-global-width: 1200px;
--svgo-pill-bg-color: #cbe2f9;
--svgo-pill-fg-color: #0b5cad;
Expand All @@ -23,7 +21,6 @@
--ifm-spacing-horizontal: 1rem;
--search-local-hit-background: var(--svgo-sec-bg-color);

font-family: var(--svgo-font-sans);
color: var(--svgo-pri-fg-color);
}

Expand All @@ -48,9 +45,8 @@
.button {
--ifm-button-color: var(--svgo-pri-bg-color);
--ifm-button-background-color: var(--svgo-pri-fg-color);
--ifm-button-border-color: var(--svgo-pri-fg-color);
}
.button:hover {
.button:hover, .button:focus {
--ifm-button-background-color: var(--svgo-button-hover-background-color);
}

Expand All @@ -75,7 +71,7 @@
nav input {
background-color: var(--svgo-search-bg-color) !important;
}
nav input:hover {
nav input:hover, nav input:focus {
background-color: var(--svgo-search-bg-hover) !important;
}
nav div kbd {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function HomepageHeader() {
SVGO and its various integrations will enable you to optimize
SVGs and serve your web applications faster.
</p>
<div className={styles.buttons}>
<div>
<Link
className="button button--lg"
to="/docs/introduction">
Expand Down
2 changes: 1 addition & 1 deletion src/pages/index.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
display: inline-flex;
align-items: center;
user-select: none;
font-family: var(--svgo-font-mono);
font-family: var(--ifm-font-family-monospace);
cursor: copy;
}

Expand Down

0 comments on commit ab6e3e0

Please sign in to comment.