Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to allow for Laravel 11 and Laravel JSON:API v5 support #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Westie
Copy link

@Westie Westie commented Jan 17, 2025

Description

Updates composer.json to allow for Laravel 11 and JSON:API v5.x support. Also includes bump to support PHPUnit 10 and/or PHPUnit 11 as required.

Motivation and context

Needed for Laravel 11 support.

How has this been tested?

PHPUnit 11.5.3 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.9
Configuration: /Users/david.weston/www-data/openapi-spec-generator/phpunit.xml.dist

........                                                            8 / 8 (100%)

Time: 00:01.263, Memory: 46.50 MB

OK (8 tests, 15 assertions)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@Westie
Copy link
Author

Westie commented Jan 17, 2025

Actually, a question: should laravel-json-api/hashids be natively supported as part of this library?

I'll update this PR when I have an answer on laravel-json-api/hashids#2

@Westie Westie changed the title Update to allow for Laravel 11 and Laravel JSON:API v5 support Blocked: Update to allow for Laravel 11 and Laravel JSON:API v5 support Jan 17, 2025
@JaZo JaZo requested a review from Rocksheep January 17, 2025 08:46
@Rocksheep
Copy link
Collaborator

Thank you for contributing to the project. I see that laravel-json-api/hashids#2 has been merged. Kan you update the PR to use the new version?

@Westie
Copy link
Author

Westie commented Jan 20, 2025

@Rocksheep thanks for the ping! now that upstream has been properly versioned, there's new requirements that ultimately demand newer versions of phpunit

I've now sorted out the deprecation errors

@Westie Westie changed the title Blocked: Update to allow for Laravel 11 and Laravel JSON:API v5 support Update to allow for Laravel 11 and Laravel JSON:API v5 support Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants