Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codestyle to use Pint instead of php-cs-fixer and make PHP 8.1 minimum required version #25

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

Rocksheep
Copy link
Collaborator

Description

The codestyle has now been changed to laravel/pint in order to match with our other projects. This also needed the mimium version of PHP to be increased to PHP8.1. This was already planned to be done so I have done it now to speed things up.

Motivation and context

It updates the codestyle to the standards of Laravel and SWIS

How has this been tested?

Has not been tested as it's only codestyle and minimum version bump. This might

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

.github/workflows/lint.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@Rocksheep Rocksheep force-pushed the feature/update-codestyle branch from f6d6c90 to 4729274 Compare January 31, 2025 14:49
@Rocksheep Rocksheep requested a review from JaZo January 31, 2025 14:49
@Rocksheep Rocksheep merged commit bca1883 into master Jan 31, 2025
13 checks passed
@Rocksheep Rocksheep deleted the feature/update-codestyle branch February 2, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants