Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump some deps #1667

Merged
merged 5 commits into from
Nov 19, 2023
Merged

chore: bump some deps #1667

merged 5 commits into from
Nov 19, 2023

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Nov 18, 2023 •
edited
Loading

housekeeping

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 0:57am
t3-upgrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2023 0:57am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 137c1bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliusmarminge
Copy link
Member Author

juliusmarminge commented Nov 18, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@juliusmarminge juliusmarminge mentioned this pull request Nov 18, 2023
Merged
@github-actions github-actions bot added 📚 documentation Improvements or additions to documentation 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Nov 18, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 91
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://create-t3-app-git-11-18-bumpdeps-t3-oss.vercel.app/

This was referenced Nov 18, 2023
Closed
Merged
c-ehrlich
c-ehrlich approved these changes Nov 19, 2023
View reviewed changes
cli/src/installers/trpc.ts
Comment on lines 60 to +70
usingAuth && usingPrisma
? "with-auth-prisma.ts"
: usingAuth && usingDrizzle
? "with-auth-drizzle.ts"
: usingAuth
? "with-auth.ts"
: usingPrisma
? "with-prisma.ts"
: usingDrizzle
? "with-drizzle.ts"
: "base.ts";
? "with-auth-drizzle.ts"
: usingAuth
? "with-auth.ts"
: usingPrisma
? "with-prisma.ts"
: usingDrizzle
? "with-drizzle.ts"
: "base.ts";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match cant land soon enough 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haah

@juliusmarminge
Copy link
Member Author

juliusmarminge commented Nov 19, 2023 •
edited
Loading

Merge activity

Base automatically changed from 11-18-use_type_module to main November 19, 2023 12:57
@github-actions GitHub Actions
Copy link
Contributor

Hey t3-oss/translators!

This PR contains changes to your language. Please review the changes ❤️.

@juliusmarminge juliusmarminge merged commit 43cc10b into main Nov 19, 2023
73 checks passed
@juliusmarminge juliusmarminge deleted the 11-18-bump_deps branch November 19, 2023 12:58
@github-actions github-actions bot mentioned this pull request Nov 19, 2023
Merged
bai
bai reviewed Nov 20, 2023
View reviewed changes
cli/template/base/_eslintrc.cjs
@@ -6,7 +6,7 @@ const config = {
},
plugins: ["@typescript-eslint"],
extends: [
"next/core-web-vitals",
"plugin:@next/next/recommended",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change makes checks less strict by removing errors for:

  • '@next/next/no-html-link-for-pages': 'error',
  • '@next/next/no-sync-scripts': 'error',

Out of curiosity - why did you decide to change this? (Asking since I'm genuinely curious 🙏)

devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@juliusmarminge
chore: bump some deps (t3-oss#1667)
889f6c7 
housekeeping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bai bai bai left review comments

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln nexxeln is a code owner

@t3dotgg t3dotgg Awaiting requested review from t3dotgg t3dotgg is a code owner

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusmarminge @bai @c-ehrlich